Don't set properties on existing Azure SQL server resources#7705
Merged
captainsafia merged 5 commits intomainfrom Feb 20, 2025
Merged
Don't set properties on existing Azure SQL server resources#7705captainsafia merged 5 commits intomainfrom
captainsafia merged 5 commits intomainfrom
Conversation
captainsafia
force-pushed
the
safia/azure-sql-existing
branch
from
b030fef to
8d73431
Compare
Add a link to Azure.Provisioning issue.
eerhardt
reviewed
Feb 20, 2025
|
|
||
| /// <remarks> | ||
| /// Workaround for issue using SqlServerAzureADAdministrator. | ||
| /// See https://github.com/Azure/azure-sdk-for-net/issues/48364 for more information. |
Member
There was a problem hiding this comment.
FYI @tg-msft - this is how we figured to work around this issue.
eerhardt
reviewed
Feb 20, 2025
| return new StringLiteralExpression("ActiveDirectory"); | ||
| } | ||
|
|
||
| protected override void DefineProvisionableProperties() |
Member
There was a problem hiding this comment.
@tg-msft this is the workaround, notice we don't call base here. We just define the 4 properties we need.
eerhardt
approved these changes
Feb 20, 2025
Member
eerhardt
left a comment
eerhardt
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the fix!
Hopefully we can remove the workaround once the Azure.Provisioning issue is fixed.
I think we should backport this to 9.1.
Contributor
Author
|
/backport to release/9.1 |
Contributor
|
Started backporting to release/9.1: https://github.com/dotnet/aspire/actions/runs/13428002254 |
github-actions
bot
added
the
area-app-model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Avoid setting fields that will be emitted in the
propertiesof the Bicep file for Azure SQL server resources that already exist. Instead, add a SQL Admin through SqlServerAzureADAdministrator child resource.Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):